[PATCH] Re: s3: smb2 read sendfile

sebastien.laveze at mindspeed.com sebastien.laveze at mindspeed.com
Tue Oct 30 04:48:43 MDT 2012


Hi metze,

> > So guess the correct check would be more like it is in stable 
branches:
> > 
> > smb2req->in.vector_count != (SMBD_SMB2_NUM_IOV_PER_REQ + 1)
> > 
> > I mostly want to be sure I'm not gonna break something with this fix.
> 
> While this is a possible fix for now, I'd prefer
> 
> smb2req->in.vector_count >= (2*SMBD_SMB2_NUM_IOV_PER_REQ)
> 
> As I'd like to remove the magic '1' in future and completely hide the
> transport (NBT) header.
> 
> Can you verify the attached patch also works for you?

Yes works fine ! Just verified on my system.

Thanks,
Sebastien


More information about the samba-technical mailing list