[PATCH] Re: s3: smb2 read sendfile

[Michael Adam]

Hi Sebasiten,

On 2012-10-30 at 11:48 +0100, sebastien.laveze at mindspeed.com wrote:
> Hi metze,
> 
> > > So guess the correct check would be more like it is in stable 
> branches:
> > > 
> > > smb2req->in.vector_count != (SMBD_SMB2_NUM_IOV_PER_REQ + 1)
> > > 
> > > I mostly want to be sure I'm not gonna break something with this fix.
> > 
> > While this is a possible fix for now, I'd prefer
> > 
> > smb2req->in.vector_count >= (2*SMBD_SMB2_NUM_IOV_PER_REQ)
> > 
> > As I'd like to remove the magic '1' in future and completely hide the
> > transport (NBT) header.
> > 
> > Can you verify the attached patch also works for you?
> 
> Yes works fine ! Just verified on my system.

I have reviewed the patch, too, and would push it to our master
branch. Since you reported the probelem, and tested the patch, I would like
to add attribution to the commit, if you are OK with it.

Having only your email address, and not the complete spelling of
your real name, I came up with the message in the
attached patch file...

Cheers - Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-smb2_read-fix-SMBD_SMB2_NUM_IOV_PER_REQ-check-for.patch
Type: text/x-patch
Size: 1142 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121030/a85b6636/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 206 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121030/a85b6636/attachment.pgp>