review tools (was Re: Code review required for commits - formal Team vote.)

David Disseldorp ddiss at
Wed Oct 17 15:37:07 MDT 2012

On Wed, 17 Oct 2012 11:37:34 -0400
simo <idra at> wrote:

> > Great, I volunteer to use it too. Let me know if I can do anything
> > regarding setup.
> > Until then I recommend developers get acquainted with git send-email.  
> Is git send-mail required ? Or does patchworks function with normal
> attachments as well ?

Not required, just quicker and easier :)
AFAICT patches must either be inline or as text attachments (mime-type

Cheers, David

More information about the samba-technical mailing list