review tools (was Re: Code review required for commits - formal Team vote.)

simo idra at
Wed Oct 17 09:37:34 MDT 2012

On Wed, 2012-10-17 at 17:32 +0200, David Disseldorp wrote:
> On Wed, 17 Oct 2012 11:12:29 -0400
> simo <idra at> wrote:
> > > For an look at patchwork in action, see:
> > >  
> > 
> > Sounds nice and it seem that thanks to the git hook it should work even
> > if it is not used by everybody, meaning we could set it up now and just
> > let it run and let it be used by whoever wants to use it.
> > Is that right ?
> Yes, that's correct.
> > If so I can volunteer to use it and even to set it up, heck even host
> > it.
> Great, I volunteer to use it too. Let me know if I can do anything
> regarding setup.
> Until then I recommend developers get acquainted with git send-email.

Is git send-mail required ? Or does patchworks function with normal
attachments as well ?

> > However I am afraid we may need to create a separate mailing list for
> > reviews/patches in order to avoid drowning other technical discussions ?
> "PATCH" is easy to filter out, but I'm not too concerned either way.

I guess we can start with -technical and move later if necessary.


Simo Sorce
Samba Team GPL Compliance Officer <simo at>
Principal Software Engineer at Red Hat, Inc. <simo at>

More information about the samba-technical mailing list