Code review required for commits - formal Team vote.

Kai Blin kai at
Sun Oct 14 17:23:22 MDT 2012

Hash: SHA1

On 2012-10-15 01:05, Michael Adam wrote:

> * I believe that such a trial can only work if the team as a whole
> commits to testing mandatory review for a certain period of time,
> after which it can be decided whether we want to move forward with
> rooting mandatory review into a formal policy.

That's a pretty big difference from what Jeremy called the vote on,
which had neither a fixed timespan for said trial, nor the idea that
we'd decide to adopt or reject the new policy after the trial. The
original proposal had "get a new vote if you don't like it".

> I suggest that we try this for 3-4 months. After that timeframe we
> should evaluate the outcome. If all goes well, we would have 
> elaborated a process and formal requirement that we could put into
> a policy. If we meet impossible obstacles before that instead, we
> need to revise and re-discuss earlier of course. But I think we
> need to give it at least a couple of weeks' time to make a
> meaningful statement.

I can live with this proposal.


- -- 
Kai Blin
Worldforge developer
Wine developer
Samba team member
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla -


More information about the samba-technical mailing list