Provision DNS patches

Ricky Nance ricky.nance at weaubleau.k12.mo.us
Sat Oct 13 16:11:04 MDT 2012


Is there something wrong on this that I need to fix? Do I need to split it
into two patches? Please advise.

Thanks,
Ricky

On Mon, Oct 8, 2012 at 7:16 AM, Ricky Nance <ricky.nance at weaubleau.k12.mo.us
> wrote:

> I originally had them split, then had a few issues with git (still
> learning) and ended up with both in one commit. As for the upper case, this
> just lowers the questions, but doesn't change the case of the variable, so
> it makes provision more aesthetically pleasing while still retaining full
> functionality.
>
> Ricky
>
>
> On Mon, Oct 8, 2012 at 1:11 AM, Matthieu Patou <mat at samba.org> wrote:
>
>> On 10/07/2012 09:21 PM, Ricky Nance wrote:
>>
>>> See attached.
>>>
>>> Ricky
>>>
>> Hello Ricky,
>>
>> Thanks for your patch, here you try to put 2 changes in one patch it
>> would be better to split in 2 patches: 1 for the dns forwarder and 1 for
>> the backend.
>>
>> Concerning the uppercase change, have you checked that those values are
>> not used somewhere else ? I think that the samba_upgradedns should be
>> changed as well and most probably some other scripts.
>>
>> Matthieu.
>>
>> --
>> Matthieu Patou
>> Samba Team
>> http://samba.org
>>
>>
>
>
> --
>
>
>


--


More information about the samba-technical mailing list