Code review required for commits - Discuss.

Alexander Bokovoy ab at
Sat Oct 13 07:54:48 MDT 2012

On Fri, Oct 12, 2012 at 8:16 PM, Jeremy Allison <jra at> wrote:
> On Fri, Oct 12, 2012 at 09:18:01AM +0200, Volker Lendecke wrote:
>> The main reason for me to like and +1 the "you can't push
>> your own stuff, reviewer must push" is a purely
>> psychological one. If I have to push the code that I review,
>> this puts significantly more pressure on me to do more
>> careful review. Just +1ing a patch is way too easy to force
>> me to do proper review.
> This, this a thousand times this !
> Pushing a patch if far more commitment than simply
> doing a +1.
> For that reason alone I really want reviewer-push
> to be adopted as soon as possible.

/ Alexander Bokovoy

More information about the samba-technical mailing list