Code review required for commits - Discuss.
jra at samba.org
Fri Oct 12 14:31:13 MDT 2012
On Sat, Oct 13, 2012 at 07:29:53AM +1100, Andrew Bartlett wrote:
> On Fri, 2012-10-12 at 10:16 -0700, Jeremy Allison wrote:
> > On Fri, Oct 12, 2012 at 09:18:01AM +0200, Volker Lendecke wrote:
> > >
> > > The main reason for me to like and +1 the "you can't push
> > > your own stuff, reviewer must push" is a purely
> > > psychological one. If I have to push the code that I review,
> > > this puts significantly more pressure on me to do more
> > > careful review. Just +1ing a patch is way too easy to force
> > > me to do proper review.
> > This, this a thousand times this !
> > Pushing a patch if far more commitment than simply
> > doing a +1.
> > For that reason alone I really want reviewer-push
> > to be adopted as soon as possible.
> What is the reason for the sudden, urgent and overbearing rush here?
Because I'm worried about our code quality, and the long
term security of the project. I see it as an serious issue
that needs addessing asap.
More information about the samba-technical