Code review required for commits - Discuss.

Matthieu Patou mat at
Fri Oct 12 13:00:05 MDT 2012

On 10/12/2012 11:54 AM, Jeremy Allison wrote:
> On Fri, Oct 12, 2012 at 11:52:26AM -0700, Matthieu Patou wrote:
>>> I haven't seen the case where a simple patch didn't get
>>> a prompt ack.
>> I've got two examples of things that comes to my mind:
>> * dirsync control implementation
>> * pseudo-backlink
>> I took me ages to get a review on both (2/3 weeks), and I'm sure if
>> I dig in my memory there is more like that.
> Sure, we all have examples of these things. The goal is
> to fix that by making review a more important part of
> the job.
> If you need a reviewer to get your own code in, then
> (hopefully) you'll be a much more diligent reviewer
> yourself.
As I said this is based on assumption that someone will ask me to review.
I'm not sure that it will be the case very very often.

Ok I think we have to move one because I can't convince you of my fears 
and you can't give me the insurance that will quiet them.


Matthieu Patou
Samba Team

More information about the samba-technical mailing list