Code review required for commits - Discuss.

Jeremy Allison jra at
Fri Oct 12 12:54:23 MDT 2012

On Fri, Oct 12, 2012 at 11:52:26AM -0700, Matthieu Patou wrote:
> >
> >I haven't seen the case where a simple patch didn't get
> >a prompt ack.
> I've got two examples of things that comes to my mind:
> * dirsync control implementation
> * pseudo-backlink
> I took me ages to get a review on both (2/3 weeks), and I'm sure if
> I dig in my memory there is more like that.

Sure, we all have examples of these things. The goal is
to fix that by making review a more important part of
the job.

If you need a reviewer to get your own code in, then
(hopefully) you'll be a much more diligent reviewer


More information about the samba-technical mailing list