Code review required for commits - Discuss.

[Kai Blin]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2012-10-12 10:20, Volker Lendecke wrote:

> Just be a PITA for the reviewers. Send mails, call them, start to
> use other means like hop on a train to Goettingen with a LART tool
> :-)

That's a reasonable effort for people who work on Samba on their
dayjob. I've got to take at least one day off at work to get to
Göttingen. On the worst case scenario, that limits me to 30 patchsets
a year, assuming I spend all my vacation getting patches in. ;)

I'm still worried that this system is going to leak patches,
especially if we don't allow for pushes after patches were ignored for
a while.

I think if we go towards a required review system, we really, really
need to make sure we don't drop patches.

Cheers,
Kai

- -- 
Kai Blin
Worldforge developer http://www.worldforge.org/
Wine developer http://wiki.winehq.org/KaiBlin
Samba team member http://www.samba.org/samba/team/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iEYEARECAAYFAlB34xEACgkQEKXX/bF2FpQdWACeJ3zm0HuMheERreMxvgl+FEKR
tMUAn2p45oIH72tUEi/a2AyGcD34z+3i
=POuv
-----END PGP SIGNATURE-----