Code review required for commits - Discuss.

[Kai Blin]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2012-10-12 09:38, Michael Adam wrote:

Hi,

> Ok, the main point is this:
> 
> Change "review" from a matter of interest to a required step in
> our software development.
> 
> Hence, I am inclinend to change my proposal to:
> 
> * we should _not_ allow a free push pass after any number of days 
> at all.

Ok, as the one who works on an area that sees little interest at all
until things break, how do I make sure I get my code in?

Wine has a "only benevolent dictator may push" system, but Alexandre
never ever misses a patch. There, if my code is acceptable, I'm sure
it'll get in without me having to run around the mailing list pleading
for a review.

I see this system work fine for areas where lots of people are
interested, but what about the areas most people consider boring?

Cheers,
Kai

- -- 
Kai Blin
Worldforge developer http://www.worldforge.org/
Wine developer http://wiki.winehq.org/KaiBlin
Samba team member http://www.samba.org/samba/team/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iEYEARECAAYFAlB30dEACgkQEKXX/bF2FpR3JACghBKHMpaLz3vj7zTj2d8K2Dvo
8kYAnjjp7H3D1ciQEMugpUJ7A16Lh5Ca
=C6GZ
-----END PGP SIGNATURE-----