Code review required for commits - Discuss.

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri Oct 12 02:20:23 MDT 2012


On Fri, Oct 12, 2012 at 10:16:21AM +0200, Kai Blin wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 2012-10-12 09:38, Michael Adam wrote:
> 
> Hi,
> 
> > Ok, the main point is this:
> > 
> > Change "review" from a matter of interest to a required step in
> > our software development.
> > 
> > Hence, I am inclinend to change my proposal to:
> > 
> > * we should _not_ allow a free push pass after any number of days 
> > at all.
> 
> Ok, as the one who works on an area that sees little interest at all
> until things break, how do I make sure I get my code in?

Just be a PITA for the reviewers. Send mails, call them,
start to use other means like hop on a train to Goettingen
with a LART tool :-)

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de


More information about the samba-technical mailing list