abee79f vfs: Use posix_sys_acl_blob_get_file in vfs_gpfs for posix ACLs

simo idra at samba.org
Thu Oct 11 10:50:16 MDT 2012

On Thu, 2012-10-11 at 09:37 -0700, Jeremy Allison wrote:
> On Thu, Oct 11, 2012 at 12:32:12PM -0400, simo wrote:
> > 
> > Given the above 'incident' is not an isolated episode but happens
> > frequently, I say +1
> > I already generally get a sign-off from reviewers and let them push
> > anyway.
> This should not be about what you do, or what Andrew does.
> This should be a Team decision made to help improve the
> quality of the code overall, and that's what I'm proposing.

I agree, sorry for ranting on this specific episode, I agree on the
proposal in general.

> If it helps people - this is exactly what we do here @ Google.
> I know we don't have Google's resources, but we should note
> best practices in the area.

Just for the record, in all my other projects @ Red Hat (big and small
except for one-man ones) we use a review before commit approach that
works quite well too.


Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>

More information about the samba-technical mailing list