reviewing my own changes... :-)

Andrew Bartlett abartlet at samba.org
Sun Nov 11 15:37:05 MST 2012


On Sun, 2012-11-11 at 23:27 +0100, Jelmer Vernooij wrote:
> On Sun, Nov 11, 2012 at 03:49:02PM +0100, Andrew Bartlett wrote:
> > The branch, master has been updated
> >        via  1d81e52 selftest: Add tests for expected behaviour on directories as well as files
> >        via  a6a0155 pysmbd: Add SMB_ACL_EXECUTE to the mask set by make_simple_acl()
> >        via  312f8dd selftest: Make samba.tests.ntacl also use TestCaseInTempDir
> >        via  b4d8629 samba-tool: Rework ldap attribute fetch in classicupgrade for missing attributes
> >       from  c06d602 s3:smbd: Fix typo in got_duplicate_group check
> > 
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> > 
> > 
> > - Log -----------------------------------------------------------------
> > commit 1d81e52bba65f05378db7027537aa27eb5bfa70a
> > Author: Andrew Bartlett <abartlet at samba.org>
> > Date:   Sun Nov 11 21:33:41 2012 +1100
> > 
> >     selftest: Add tests for expected behaviour on directories as well as files
> >     
> >     This is important because it covers the codepath which had the talloc
> >     error fixed by commit 60cf4cb5a630506747431ecbf00d890509baf2f3
> >     (vfs_acl_common: In add_directory_inheritable_components allocate on
> >     psd as parent)
> >     
> >     Andrew Bartlett
> >     
> >     Signed-off-by: Andrew Bartlett <abartlet at samba.org>
> >     Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
> >     Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> You've reviewed your own changes ? I'm shocked. :-) Is this a
> script gone crazy perhaps ?

Yeah, I've been trying out obnox's script, which is handy even for my
own changes to quickly change to tag from my name to yours after your
mailing list ack.  I think the issue is I've got both the pre and post
commit hooks in...

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org




More information about the samba-technical mailing list