reviewing my own changes... :-)

Michael Adam obnox at samba.org
Mon Nov 12 02:14:29 MST 2012


On 2012-11-12 at 09:37 +1100, Andrew Bartlett wrote:
> On Sun, 2012-11-11 at 23:27 +0100, Jelmer Vernooij wrote:
> > On Sun, Nov 11, 2012 at 03:49:02PM +0100, Andrew Bartlett wrote:
> > > The branch, master has been updated
> > >        via  1d81e52 selftest: Add tests for expected behaviour on directories as well as files
> > >        via  a6a0155 pysmbd: Add SMB_ACL_EXECUTE to the mask set by make_simple_acl()
> > >        via  312f8dd selftest: Make samba.tests.ntacl also use TestCaseInTempDir
> > >        via  b4d8629 samba-tool: Rework ldap attribute fetch in classicupgrade for missing attributes
> > >       from  c06d602 s3:smbd: Fix typo in got_duplicate_group check
> > > 
> > > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> > > 
> > > 
> > > - Log -----------------------------------------------------------------
> > > commit 1d81e52bba65f05378db7027537aa27eb5bfa70a
> > > Author: Andrew Bartlett <abartlet at samba.org>
> > > Date:   Sun Nov 11 21:33:41 2012 +1100
> > > 
> > >     selftest: Add tests for expected behaviour on directories as well as files
> > >     
> > >     This is important because it covers the codepath which had the talloc
> > >     error fixed by commit 60cf4cb5a630506747431ecbf00d890509baf2f3
> > >     (vfs_acl_common: In add_directory_inheritable_components allocate on
> > >     psd as parent)
> > >     
> > >     Andrew Bartlett
> > >     
> > >     Signed-off-by: Andrew Bartlett <abartlet at samba.org>
> > >     Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
> > >     Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> > You've reviewed your own changes ? I'm shocked. :-) Is this a
> > script gone crazy perhaps ?

Nice one, but not bad, since Sign-off is understood to imply reviewed by.

> Yeah, I've been trying out obnox's script, which is handy even for my
> own changes to quickly change to tag from my name to yours after your
> mailing list ack.  I think the issue is I've got both the pre and post
> commit hooks in...

I rather think it is that you called with REVIEW set, while you
are the author?

REVIEW=1 will let the script(s) add your review tag (if it is not already set)
SIGN=1 will let the script(s) add the author's signoff tag (if it is not already present)

Maybe I should add a check to not add reviewed-by if the caller
is the author..

Cheers - Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 206 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121112/b25cc16a/attachment.pgp>


More information about the samba-technical mailing list