[SCM] Samba Shared Repository - branch master updated

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed May 30 06:43:10 MDT 2012


On Wed, May 30, 2012 at 02:29:13PM +0200, Kai Blin wrote:
> On 2012-05-30 12:17, Volker Lendecke wrote:
> 
> > If nobody objects, I will push the attached patch by the end
> > of this week.
> 
> I'll object.

Ok. I'll not push it.

> I don't think only providing anti-patterns is what we want
> to go for for README.Coding. Don't just tell people what not to do, tell
> them what to do instead. The rest of the file always has "Good" and
> "Bad" examples.
> 
> As Simo mentioned, consistency is important, so please if you don't like
> the macro, provide a canonical replacement for it.

The problem is that there is no canonical replacement, as
the variety of macros is so large. I can certainly go
through all the macros and expand them manually, but this
from my point of view does not provide any additional
information beyond the "please don't use control-flow
changing macros".

Sorry for not being able to provide an appropriate wording.
Probably this is just too complex a topic to be put into
README.Coding, and we will have to live with people using
and people not using them.

With best regards,

Volker Lendecke

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de


More information about the samba-technical mailing list