[SCM] Samba Shared Repository - branch master updated

Michael Adam obnox at samba.org
Wed May 30 05:22:11 MDT 2012

Volker Lendecke wrote:
> On Wed, May 30, 2012 at 02:36:03AM +0200, Kai Blin wrote:
> > The branch, master has been updated
> >        via  aa01908 libcli/dns: Rename UDP-based calls to reflect their use
> >        via  42e1b94 Add myself as libcli/dns maintainer
> >        via  6a1ad76 s4-dns: Use W_ERROR_HAVE_NO_MEMORY in create_response_rr
> Where is the rule laid down that we must use those macros?

As a mathematician, you know that the fact that someone uses this
macro, does not imply that we have a rule that we must use then.... 8-}

(even if someone changes existing code to use them - maybe he likes them)

> I find them completely obnoxious to use. Doing a return or goto
> from something that looks like a function call is just wrong to
> me.

That is is a good argument.
Having used these macros myself in the past, I would agree to ban them.

> To save precious screen space, I would rather go and
> introduce a special rule to say
> if (ptr == NULL) { return WERR_NOMEM };


Let's not discuss about some lines of code less.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 206 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120530/c204170b/attachment.pgp>

More information about the samba-technical mailing list