Patch possible?

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri May 25 06:19:51 MDT 2012


Hi!

Does the attached patch break the libsmbclient abi promise?
It survives autobuild on sn-devel, thus the abi checker
seems happy.

Thanks,

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
>From 803fa1e626dbe549d225883375cfb92be7827413 Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Fri, 25 May 2012 10:15:08 +0200
Subject: [PATCH] s3-libsmbclient: Make SMBC_call_auth_fn static

---
 source3/include/libsmb_internal.h |    9 ---------
 source3/libsmb/libsmb_server.c    |    2 +-
 2 files changed, 1 insertions(+), 10 deletions(-)

diff --git a/source3/include/libsmb_internal.h b/source3/include/libsmb_internal.h
index 0c8d8ab..92694f3 100644
--- a/source3/include/libsmb_internal.h
+++ b/source3/include/libsmb_internal.h
@@ -450,15 +450,6 @@ SMBC_remove_unused_server(SMBCCTX * context,
                           SMBCSRV * srv);
 
 void
-SMBC_call_auth_fn(TALLOC_CTX *ctx,
-                  SMBCCTX *context,
-                  const char *server,
-                  const char *share,
-                  char **pp_workgroup,
-                  char **pp_username,
-                  char **pp_password);
-
-void
 SMBC_get_auth_data(const char *server, const char *share,
                    char *workgroup_buf, int workgroup_buf_len,
                    char *username_buf, int username_buf_len,
diff --git a/source3/libsmb/libsmb_server.c b/source3/libsmb/libsmb_server.c
index f5fcaea..57f479c 100644
--- a/source3/libsmb/libsmb_server.c
+++ b/source3/libsmb/libsmb_server.c
@@ -95,7 +95,7 @@ SMBC_remove_unused_server(SMBCCTX * context,
 /****************************************************************
  * Call the auth_fn with fixed size (fstring) buffers.
  ***************************************************************/
-void
+static void
 SMBC_call_auth_fn(TALLOC_CTX *ctx,
                   SMBCCTX *context,
                   const char *server,
-- 
1.7.5.4



More information about the samba-technical mailing list