Success story with patch: Samba4 on FreeBSD - one year in production

[Andrew Bartlett]

On Thu, 2012-05-24 at 20:01 +0300, Andriy Syrovenko wrote:
> Hi,
> 
> Please find attached the first part of the revised patch. It addresses
> the issue with some dependencies being installed in /usr/local and
> eliminates the dependency on the external uuid library.
> 
> It turned out that from all the external dependencies, location of
> only two packages needs to be specified explicitly. These are iconv
> and gettext, so I added the '--with-gettext' option (in addition to
> the already existing '--with-libiconv') and defaulted it to
> /usr/local. Other packages are being found through pkg-config, except
> openldap-client which anyway magically gets located in /usr/local (and
> I don't really understand how it's done).
> 
> If this patch is acceptable, then I'll look into the remaining part
> which is moving the extattr-related code in
> source3/lib/system.c to lib/replace.

That patch looks great!

To give you proper credit, could you put them into individual patches,
commit them into git and then export them with (say) 'git-format-patch
-3'?

https://wiki.samba.org/index.php/Using_Git_for_Samba_Development has
some hints. 

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org