[SCM] Samba Shared Repository - branch master updated

[Volker Lendecke]

On Fri, May 18, 2012 at 11:39:09AM -0700, Jeremy Allison wrote:
> On Fri, May 18, 2012 at 08:08:00PM +0200, Volker Lendecke wrote:
> > 
> > I will be fine with it if comes as part of the general rule
> > I proposed a while ago that you can't push your own patches.
> > Making an exception for a revert does not make sense.
> > Technically, I did not do reverts not to blow up commit
> > count unnecessarily, I created a new patch that undoes the
> > changes. This code was not ready as I posted it, and it did
> > cause severe problems for Andrew. So the only sane thing was
> > to pull them as quickly as autobuild would allow it. This
> > way Andrew was no longer blocked in his work.
> 
> I am watching you talking yourself into the mindset of "I was
> right to revert". I don't think that is the case.
> 
> What *specific* problems did the patch cause ?

DIR1 gave timeouts. See Andrew's mails. He did not say that
it were these patches specificially, but he suspected that
they might be it.

> Don't just say "autobuild" flakeyness. I had a conversation
> with Andrew myself a day or so ago where he commented that
> he wanted to push his ACL patches that I had reviewed as
> "he currently had the time to nurse them past the current
> autobuild" flakeyness. So no, I am of the opinion that
> this patchset did not cause any extra autobuild problems.

Read his mail:

> I certainly suspect that something is up with these patches,
> or other           
> recent development.  There is a another flaky samba3 test
> that wasn't           
> there before today.  See my other thread.  It took me most
> of today to          
> get an autobuild in. 

This is enough for me as an indication something is bloody
wrong with my work. Given that I could not analyze in a
timely manner what I broke I pulled it.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de