[SCM] Samba Shared Repository - branch master updated
Volker.Lendecke at SerNet.DE
Fri May 18 12:28:29 MDT 2012
On Fri, May 18, 2012 at 11:20:25AM -0700, Jeremy Allison wrote:
> On Fri, May 18, 2012 at 02:15:26PM -0400, simo wrote:
> > On Fri, 2012-05-18 at 20:09 +0200, Volker Lendecke wrote:
> > > >
> > > > +1
> > > >
> > > > A revert is a serious matter.
> > >
> > > Sorry, but this case is different. It was *MY* code that I
> > > posted completely prematurely. I claim the right to revert
> > > them when they cause problems for other developers.
> > If another developer has actual issues you'll have no problem getting
> > his ack before pushing the revert.
> Indeed - that is the point. Once code is out there, and
> someone else has gone through the work of evaluating and
> deciding it's a significant improvement (which this code
> *IS* btw - but I know you know that :-) then you can't
> just arbitrarily revert and take it back.
> It's not working within a Team to do so.
> Ok, you feel you posted it prematurely, sorry about
> that. But once it's reviewed and pushed common courtesy
> says you should consult with others before reverting.
> It simply isn't your code anymore at that point, it's
> project code.
What part of "Andrew B. suspected those patches to block
him" is so difficult to understand?
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical