[SCM] Samba Shared Repository - branch master updated
Volker.Lendecke at SerNet.DE
Fri May 18 12:08:00 MDT 2012
On Fri, May 18, 2012 at 10:41:05AM -0700, Jeremy Allison wrote:
> On Fri, May 18, 2012 at 07:38:05PM +0200, Volker Lendecke wrote:
> > Hi!
> > Those patches apparently created flaky builds for Andrew
> > Bartlett, thus I took them back.
> Unfortunately this is not the correct way to address
> that issue. I pushed those patches, not you - and if
> there were problems with them we should have worked
> together to find the problem and *collaboratively*
> fixed them.
Again I have to apologize for posting those patches to a
publically accessible branch before I had made sure they
survive autobuild fine. I had asked for comments, not for
them getting pushed. Sorry that I was not making that clear
enough in my request for comments/review.
> I'd like to propose that all reverts must be
> reviewed by one other Team member other than
> the one proposing the revert. It's a code
> change at that point, and should be treated
> as such.
I will be fine with it if comes as part of the general rule
I proposed a while ago that you can't push your own patches.
Making an exception for a revert does not make sense.
Technically, I did not do reverts not to blow up commit
count unnecessarily, I created a new patch that undoes the
changes. This code was not ready as I posted it, and it did
cause severe problems for Andrew. So the only sane thing was
to pull them as quickly as autobuild would allow it. This
way Andrew was no longer blocked in his work.
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical