[SCM] Samba Shared Repository - branch master updated

Richard Sharpe realrichardsharpe at gmail.com
Fri May 18 11:47:23 MDT 2012


On Fri, May 18, 2012 at 10:41 AM, Jeremy Allison <jra at samba.org> wrote:
> On Fri, May 18, 2012 at 07:38:05PM +0200, Volker Lendecke wrote:
>> Hi!
>>
>> Those patches apparently created flaky builds for Andrew
>> Bartlett, thus I took them back.
>
> Unfortunately this is not the correct way to address
> that issue. I pushed those patches, not you - and if
> there were problems with them we should have worked
> together to find the problem and *collaboratively*
> fixed them.
>
> This is master, not a private branch.
>
> I'd like to propose that all reverts must be
> reviewed by one other Team member other than
> the one proposing the revert. It's a code
> change at that point, and should be treated
> as such.

I am happy with that. I typically get reviews of all my changes before
making them anyway.

-- 
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)


More information about the samba-technical mailing list