Some seeming repetition in source4/libcli/pysmb.c

[Amitay Isaacs]

Hi,

2012/3/7 Richard Sharpe <realrichardsharpe at gmail.com>:
> Hi,
>
> I was looking at source4/libcli/pysmb.c:py_smb_getacl and I saw this:
>
>        fio.query_secdesc.in.secinfo_flags = SECINFO_OWNER |
>                                                SECINFO_GROUP |
>                                                SECINFO_DACL |
>                                                SECINFO_PROTECTED_DACL |
>                                                SECINFO_UNPROTECTED_DACL |
>                                                SECINFO_DACL |
>                                                SECINFO_PROTECTED_SACL |
>                                                SECINFO_UNPROTECTED_SACL;
>
> Is there something I am missing, or is there unneeded duplication of
>
>                                                SECINFO_DACL |
>                                                SECINFO_PROTECTED_DACL |
>                                                SECINFO_UNPROTECTED_DACL |
>
> in that code?
>
> --
> Regards,
> Richard Sharpe
> (何以解憂？唯有杜康。--曹操)

Only SECINFO_DACL is repeated and that should be SECINFO_SACL. Fixed it now.

Amitay.