Some seeming repetition in source4/libcli/pysmb.c

Richard Sharpe realrichardsharpe at gmail.com
Tue Mar 6 22:28:19 MST 2012


Hi,

I was looking at source4/libcli/pysmb.c:py_smb_getacl and I saw this:

        fio.query_secdesc.in.secinfo_flags = SECINFO_OWNER |
                                                SECINFO_GROUP |
                                                SECINFO_DACL |
                                                SECINFO_PROTECTED_DACL |
                                                SECINFO_UNPROTECTED_DACL |
                                                SECINFO_DACL |
                                                SECINFO_PROTECTED_SACL |
                                                SECINFO_UNPROTECTED_SACL;

Is there something I am missing, or is there unneeded duplication of

                                                SECINFO_DACL |
                                                SECINFO_PROTECTED_DACL |
                                                SECINFO_UNPROTECTED_DACL |

in that code?

-- 
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)


More information about the samba-technical mailing list