David Disseldorp ddiss at suse.de
Tue Mar 6 04:36:51 MST 2012

Hi Volker,

Thanks a lot for looking at these changes! I'll post another round today
addressing these points...

On Tue, 6 Mar 2012 09:28:03 +0100
Volker Lendecke <Volker.Lendecke at SerNet.DE> wrote:

> Can you also augment the time_audit module? Next to
> full_audit, it is another one where all functions should be
> implemented.


> The other one is in the implementation of the async engine.
> You ordered the different _send, _done and _recv functions
> so that you do not need prototypes. While this saves a few
> lines, to me it is much easier to read if the functions are
> lexically ordered according to their call sequence. First
> the _send function, then the _done and after that the _recv
> function. This makes the async flow almost as easy to read
> as a non-async sequential flow. Can you change that? I know
> there are examples in the code that do it differently, but I
> think for new code we should adhere to this convention.

I normally like to avoid prototypes so that function argument changes
aren't too arduous, but in this case I guess any future changes would
likely only touch req or callback private data. I'll shuffle these

Cheers, David

More information about the samba-technical mailing list