Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Mar 6 01:28:03 MST 2012

Hi, David!

On Mon, Mar 05, 2012 at 03:44:47PM +0100, David Disseldorp wrote:
> Thanks for the feedback so far. I've push a new round of changes which
> add copy chunk _send and _recv VFS hooks, allowing for simplified async
> implementations. The existing vfs_default and vfs_btrfs copy chunk
> back-ends remain synchronous.

Overall this looks very good! Two quick remarks:

Can you also augment the time_audit module? Next to
full_audit, it is another one where all functions should be

The other one is in the implementation of the async engine.
You ordered the different _send, _done and _recv functions
so that you do not need prototypes. While this saves a few
lines, to me it is much easier to read if the functions are
lexically ordered according to their call sequence. First
the _send function, then the _done and after that the _recv
function. This makes the async flow almost as easy to read
as a non-async sequential flow. Can you change that? I know
there are examples in the code that do it differently, but I
think for new code we should adhere to this convention.



SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list