selftest and logfile output

[Andrew Bartlett]

On Fri, 2012-03-02 at 01:12 +0100, Michael Adam wrote:
> Hi!
> 
> Andrew Bartlett wrote:
> > On Thu, 2012-03-01 at 23:38 +0100, Volker Lendecke wrote:
> > > On Wed, Feb 29, 2012 at 12:41:13AM +0100, Volker Lendecke wrote:
> > > 
> > > I have no clue how to debug this in the autobuild system on
> > > sn-devel. Cranking up the debug level of smbd to 10 makes it
> > > fail much earlier, also with the unmodified master.
> > 
> > Just a heads-up.  I know you will find this infuriating, but the make
> > test failure with debug level 10 might be a red herring.  Any output
> > line, including from a DEBUG() starting with 'error' is counted by
> > subunit as a failure, and so will cause an autobuild to fail.  
> 
> That sounds utterly wrong. I was already wondering why smbd was
> not logging to the log file but to stdout (or err) in make test.
> WHy is that? imho it should log to a log file.

If the logs are put to a file, then they are essentially lost in the
selftest system.  A developer interactively debugging the system would
know where to look, but they will not show up in the build farm nor be
highlighted in the results of a failing test. 

That said, this situation clearly isn't perfect.  Some improvements
could be for foreground logging to include the debug header and
second-line indent, which may avoid the subunit keyword issue.  We also
seem to have lost the logs from forked child daemons in s3 (they don't
seem to filter back out the main stderr).  Clearly we should also have a
way not to log to the foreground, for intensive debugging sessions where
intact logfiles of successful tests may be valuable for analysis. 

I hope this clarifies things,

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org