Extra system/filesys.h in vfs_ipc.c
ab at samba.org
Mon Jun 11 08:24:45 MDT 2012
On Mon, Jun 11, 2012 at 4:58 PM, Andrew Bartlett <abartlet at samba.org> wrote:
> The commit below is the current reason why we fail to build on AIX.
> Now what AIX is doing in it's headers sucks (#define of all the system
> calls), but we have to live with it (renaming stuff if we have to).
> But what I'm sure metze (who is looking at this) I would like to know is
> why you think filesys.h is needed? I did a local build without it here.
> (Presumably this is coming up now - rather than back when ntvfs was new
> - due to the change in the way we do 64 bit files).
It was failing compile for me on Fedora 17. I vaguely remember there
was some issue in a missing struct definition, can't remember exact
I now tried to recompile it on fresh F17 without that include and it
worked fine, no problem.
> Andrew Bartlett
> commit 566884553ccb9c99cc3b05bc6fc84bf5efa9fae2
> Author: Alexander Bokovoy <ab at samba.org>
> Date: Wed May 2 20:59:00 2012 +0300
> s4:ntvfs: add missing headers to vfs_ipc
> vfs_ipc.c had system/kerberos.h and system/filesys.h missing
> Signed-off-by: Simo Sorce <idra at samba.org>
> diff --git a/source4/ntvfs/ipc/vfs_ipc.c b/source4/ntvfs/ipc/vfs_ipc.c
> index de4bf9f..5905e0c 100644
> --- a/source4/ntvfs/ipc/vfs_ipc.c
> +++ b/source4/ntvfs/ipc/vfs_ipc.c
> @@ -38,8 +38,10 @@
> #include "lib/socket/socket.h"
> #include "auth/credentials/credentials.h"
> #include "auth/credentials/credentials_krb5.h"
> +#include "system/kerberos.h"
> #include "system/gssapi.h"
> #include "system/locale.h"
> +#include "system/filesys.h"
> /* this is the private structure used to keep the state of an open
> ipc$ connection. It needs to keep information about all open
> Andrew Bartlett http://samba.org/~abartlet/
> Authentication Developer, Samba Team http://samba.org
/ Alexander Bokovoy
More information about the samba-technical