Stop spamming the logs with "Could not remove pid XX from serverid.tdb" messages and initiating the cleanup function on every process death.

[Jeremy Allison]

On Sat, Jun 02, 2012 at 09:52:11AM +1000, Andrew Bartlett wrote:
> On Thu, 2012-05-31 at 04:45 +0200, Jeremy Allison wrote:
> > The branch, master has been updated
> >        via  5d1a8d2 Stop spamming the logs with "Could not remove pid XX from serverid.tdb" messages and initiating the cleanup function on every process death.
> >       from  5e5f569 lib/dbwrap: make it possible to delete/store the current record during traverse
> > 
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> > 
> > 
> > - Log -----------------------------------------------------------------
> > commit 5d1a8d2a31390762c471229c2b115147ad0857fe
> > Author: Jeremy Allison <jra at samba.org>
> > Date:   Wed May 30 17:12:10 2012 -0700
> > 
> >     Stop spamming the logs with "Could not remove pid XX from serverid.tdb" messages and initiating the cleanup function on every process death.
> >     
> >     We now have many sub-processes from smbd that don't serve SMB1/SMB2 requests and
> >     don't register themselves in the serverid.tdb. Only initiate the cleanup
> >     from processes that were explicitly in the child list.
> >   
> 
> Jeremy,
> 
> I just wanted to say thanks for doing this cleanup work.  Since starting
> on s3fs, I've been a little worried about the messages (which are more
> visible due to slightly different operating conditions).  It is great to
> see them being squashed!

No problem, it was bugging me when running make test :-).

I've raised a bug to get the same thing fixed in 3.6.next
once the change passes review.