remove chain_reply() ?

[Volker Lendecke]

On Tue, Feb 28, 2012 at 04:32:55AM +0100, Stefan (metze) Metzmacher wrote:
> > Under
> > 
> > http://git.samba.org/?p=vl/samba.git/.git;a=shortlog;h=refs/heads/chain_reply
> > 
> > find a patchset that removes chain_reply() and replaces it
> > with something that I think can be understood significantly
> > easier. Possibly it should have been this way or similar
> > right from the beginning... Seems to survive make test.
> > 
> > Comments?
> 
> Do we have a tests that expects async processing as part a
> chain? Something like.
> 
> 1. NTCreateAndX "test.txt" with batch oplock
> 
> 2. NTCreateAndX "test.txt" with batch oplock + ReadAndX + Close
> 
> If that passes, I'm happy, but I fear it won't because of the
> strict sync loop in construct_reply_chain().

Right. I did not test that yet, thanks for that. But I think
the general approach to centralize parsing and marshalling
the chains is better than what we have right now.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de