[PATCHES] Improve output of wbinfo --ping-dc

[Christof Schmitt]

Volker Lendecke <Volker.Lendecke at sernet.de> wrote on 08/10/2012 02:39:54 
AM:

> On Thu, Aug 09, 2012 at 08:59:33PM -0700, Christof Schmitt wrote:
> > Andrew Bartlett <abartlet at samba.org> wrote on 08/09/2012 05:32:53 PM:
> > > With the attached patch (which I also have in autobuild), ABI 
checking
> > > (and symbol versions) are turned on for libwbclient, just as we do 
for
> > > almost all our other libraries.  This should show that you break the 
ABI
> > > by extending the number of arguments to that function call.
> > > 
> > > We then have the choice (for Samba 4.0) of formally breaking the ABI
> > > with a new major version, or adding yet another function call with 
the
> > > functionality you want. 
> > 
> > Adding a new function just to optionally return the DC name does not
> > make too much sense to me. I would suggest to change the version of
> > the library.
> 
> I'd rather go with an extra function. It's inconvenient, but
> breaking the libwbclient ABI is a LOT of trouble as well.

Here is an updated version of the patches. They now introduce a new
function wbcPingDc2 with an extra argument to return the DC name.

Regards,

Christof Schmitt || IBM || SONAS System Development || Tucson, AZ
christof.schmitt at us.ibm.com  ||  +1-520-799-2469  (T/L: 321-2469)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-winbind-Pass-ping-dc-result-to-client.patch
Type: application/octet-stream
Size: 1572 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120810/cf4c911c/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-s3-winbind-Return-the-DC-name-from-DC_PING.patch
Type: application/octet-stream
Size: 2540 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120810/cf4c911c/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-libwbclient-Add-wbcPingDc2.patch
Type: application/octet-stream
Size: 3686 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120810/cf4c911c/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-wbinfo-Improve-output-of-wbinfo-ping-dc.patch
Type: application/octet-stream
Size: 1686 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120810/cf4c911c/attachment-0003.obj>