[PATCHES] Improve output of wbinfo --ping-dc

[Andrew Bartlett]

On Fri, 2012-08-10 at 10:31 -0600, Christof Schmitt wrote:
> Volker Lendecke <Volker.Lendecke at sernet.de> wrote on 08/10/2012 02:39:54 
> AM:
> 
> > On Thu, Aug 09, 2012 at 08:59:33PM -0700, Christof Schmitt wrote:
> > > Andrew Bartlett <abartlet at samba.org> wrote on 08/09/2012 05:32:53 PM:
> > > > With the attached patch (which I also have in autobuild), ABI 
> checking
> > > > (and symbol versions) are turned on for libwbclient, just as we do 
> for
> > > > almost all our other libraries.  This should show that you break the 
> ABI
> > > > by extending the number of arguments to that function call.
> > > > 
> > > > We then have the choice (for Samba 4.0) of formally breaking the ABI
> > > > with a new major version, or adding yet another function call with 
> the
> > > > functionality you want. 
> > > 
> > > Adding a new function just to optionally return the DC name does not
> > > make too much sense to me. I would suggest to change the version of
> > > the library.
> > 
> > I'd rather go with an extra function. It's inconvenient, but
> > breaking the libwbclient ABI is a LOT of trouble as well.
> 
> Here is an updated version of the patches. They now introduce a new
> function wbcPingDc2 with an extra argument to return the DC name.

This looks good, except you can't change the ABI file like that.  

Instead, you have to change the version in nsswitch/libwbclient/wscript
and nsswitch/libwbclient/wbclient.h to 0.10, then add
nsswitch/libwbclient/ABI/wbclient.0.10.sigs to git.

This records what the ABI was for 0.9 (which is then used for the
version scripts), and then again for the new 0.10.

(It's an annoying detail I could 'just' fix, but I figure it is worth
explaining how the ABI stuff works).

Thanks!

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org