[PATCHES] Improve output of wbinfo --ping-dc

[Christof Schmitt]

Andrew Bartlett <abartlet at samba.org> wrote on 08/09/2012 05:32:53 PM:

> On Thu, 2012-08-09 at 17:54 -0600, Christof Schmitt wrote:
> > The attached patches make the output of wbinfo --ping-dc more useful
> > for problem determination:
> > 
> > 1) If there is an error from the ping attempt, return it to the
> >   client.
> > 2) Include the name of the DC that was attempted to ping.
> > 3) Remove redundant error messages.
> 
> The idea is a very good idea, but we have an implementation problem that
> you would not have noticed.
> 
> With the attached patch (which I also have in autobuild), ABI checking
> (and symbol versions) are turned on for libwbclient, just as we do for
> almost all our other libraries.  This should show that you break the ABI
> by extending the number of arguments to that function call.
> 
> We then have the choice (for Samba 4.0) of formally breaking the ABI
> with a new major version, or adding yet another function call with the
> functionality you want. 

Adding a new function just to optionally return the DC name does not
make too much sense to me. I would suggest to change the version of
the library.

Regards,

Christof Schmitt || IBM || SONAS System Development || Tucson, AZ
christof.schmitt at us.ibm.com  ||  +1-520-799-2469  (T/L: 321-2469)