[PATCHES] Improve output of wbinfo --ping-dc

[Andrew Bartlett]

On Thu, 2012-08-09 at 17:54 -0600, Christof Schmitt wrote:
> The attached patches make the output of wbinfo --ping-dc more useful
> for problem determination:
> 
> 1) If there is an error from the ping attempt, return it to the
>   client.
> 2) Include the name of the DC that was attempted to ping.
> 3) Remove redundant error messages.
> 
> With the three attached patches applied, the wbinfo output looks like
> this:
> 
> # wbinfo --ping-dc
> checking the NETLOGON dc connection to "ad1.EXAMPLE.COM" succeeded
> 
> # wbinfo --ping-dc
> checking the NETLOGON dc connection to "ad1.EXAMPLE.COM" failed
> error code was NT_STATUS_IO_TIMEOUT (0xc00000b5)
> 
> # wbinfo --ping-dc
> checking the NETLOGON dc connection to "ad1.EXAMPLE.COM" failed
> error code was NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND (0xc0000233)
> 
> Regards,
> 
> Christof Schmitt || IBM || SONAS System Development || Tucson, AZ
> christof.schmitt at us.ibm.com  ||  +1-520-799-2469  (T/L: 321-2469)

The idea is a very good idea, but we have an implementation problem that
you would not have noticed.

With the attached patch (which I also have in autobuild), ABI checking
(and symbol versions) are turned on for libwbclient, just as we do for
almost all our other libraries.  This should show that you break the ABI
by extending the number of arguments to that function call.

We then have the choice (for Samba 4.0) of formally breaking the ABI
with a new major version, or adding yet another function call with the
functionality you want. 

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-nsswitch-add-ABI-checking-and-symbol-versions-to-lib.patch
Type: text/x-patch
Size: 6493 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120810/a45cd570/attachment.bin>