[PATCH] Remove fstrngs from GROUP_MAP

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Sep 28 08:16:13 MDT 2011

On Wed, Sep 28, 2011 at 09:37:45AM -0400, simo wrote:
> Hello Team,
> After Andreas reviewed and fixed a couple of issues in this patch we
> decided to ask for an ack from the list due to the size of the patch.
> The patch is quite straightforward but touches a bunch of code as
> replacing fstring with talloced strings required also to always allocate
> the structure itself as parent due to the way functions that use the
> structure are designed.
> The patch passes make test.
> If there are no objections we will push it in autobuild.

Make test does not mean much for this I think. I would feel
better if you can ack that you did run a PDC with LDAP
backend (editposix=yes) and some samr operations involving
groups against it. This is not covered in autobuild iirc.



SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen

More information about the samba-technical mailing list