[PATCH] Remove fstrngs from GROUP_MAP

simo idra at samba.org
Wed Sep 28 08:40:09 MDT 2011

On Wed, 2011-09-28 at 16:16 +0200, Volker Lendecke wrote: 
> On Wed, Sep 28, 2011 at 09:37:45AM -0400, simo wrote:
> > Hello Team,
> > 
> > After Andreas reviewed and fixed a couple of issues in this patch we
> > decided to ask for an ack from the list due to the size of the patch.
> > 
> > The patch is quite straightforward but touches a bunch of code as
> > replacing fstring with talloced strings required also to always allocate
> > the structure itself as parent due to the way functions that use the
> > structure are designed.
> > 
> > The patch passes make test.
> > 
> > If there are no objections we will push it in autobuild.
> Make test does not mean much for this I think. I would feel
> better if you can ack that you did run a PDC with LDAP
> backend (editposix=yes) and some samr operations involving
> groups against it. This is not covered in autobuild iirc.

Make test does involve samr operations, in fact I discovered a few bugs
through make test during development.

I do not have a PDC with LDAP handy at the moment, but the LDAP side has
seen minimal change and all quite obvious so I think the tests we see in
make test may be enough to cover that part.


Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>

More information about the samba-technical mailing list