samba-tool: error handling improvements in delegation.py and samdb.py
jelmer at samba.org
Fri Oct 21 17:24:59 MDT 2011
-----BEGIN PGP SIGNED MESSAGE-----
On 21/10/11 23:56, Giampaolo Lauria wrote:
The changes in general look reasonable. I have some comments, most
related to form:
There is a lot of unnecessary reformatting of the code at the same time,
which makes it hard to spot what the actually code changes are.
The first line of the commit message is the same for all four commit
messages, it would be nice to have something more descriptive.
The error message about on|off is perhaps a bit clearer than it was
previously, but it would be even better to tell the user what actually
went wrong. E.g. "expected argument 'on' or 'off', got '%s'".
With regard to the flags string argument - it would be nice to use a
more user friendly message rather than whatever happens to be the name
of the constant in the Samba source code.
It looks like different reviewers have different preferences...
I'm not a big fan of posting links to repositories for review. It makes
it harder to provide context when replying, and that especially makes it
harder for others on the list who haven't looked at repository on GitHub
to easily track what's going on. It's also pretty hard to review
repositories on GitHub when travelling - it's a lot easier to grab an
offline copy of my entire mailbox.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
-----END PGP SIGNATURE-----
More information about the samba-technical