samba-tool: error handling improvements in delegation.py and samdb.py

[Jelmer Vernooij]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

On 21/10/11 23:56, Giampaolo Lauria wrote:

The changes in general look reasonable. I have some comments, most
related to form:

There is a lot of unnecessary reformatting of the code at the same time,
which makes it hard to spot what the actually code changes are.

The first line of the commit message is the same for all four commit
messages, it would be nice to have something more descriptive.

The error message about on|off is perhaps a bit clearer than it was
previously, but it would be even better to tell the user what actually
went wrong. E.g. "expected argument 'on' or 'off', got '%s'".

With regard to the flags string argument - it would be nice to use a
more user friendly message rather than whatever happens to be the name
of the constant in the Samba source code.



It looks like different reviewers have different preferences...

I'm not a big fan of posting links to repositories for review. It makes
it harder to provide context when replying, and that especially makes it
harder for others on the list who haven't looked at repository on GitHub
to easily track what's going on. It's also pretty hard to review
repositories on GitHub when travelling - it's a lot easier to grab an
offline copy of my entire mailbox.

Cheers,

Jelmer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJOof7+AAoJEACAbyvXKaRXnhgQAJN6AwHaeh2lQ+Cmv+D2WwX9
OR4+c/0F9yaMiRT/gsp2ZbcbA1wQX/YjYAUQ25sg7RLESOCFUcsvfueRiqDuFew7
sBxL8B7aNgmk9ibl3Qf1ikF/4Z8Uly/5erndmHUGQOQAz+vAFsF8CeyKH6BqwKh6
lUaUww0SwdejGh4m+hMcSjAbyg6UijlvVEFCk0+KE+66X1u387fGcgCBhUi0SOVF
9TvSLMhTqK32VBaztGPGLEfrMZfsYX76ap+ysEeErRs550KYWcAAULax+AjMlwCH
6esiiNfhdxDVkpW4DljdWJczGuN3qP2x4sN82tjDGaa64sWm3d9hKYCGjjqhoY2D
L0IguZLTTTEjqNBvpKLgtJVlWTij0rykiZKiXino1Qhz+oy+IIcZ2AYbfyyCbtc8
RvtVpRSg5pq7eWQ4uV0JNqb7UDq3VNfjW5TgfrTJBJQ1raWSL/IRiSu1sOztkcN1
Wsv8xbDa3C/eqGY2u/LWqYUWtjqVrXTPpS0h9wf7bIK06qwaYY3dHzkM8AlAJ1Xr
72ZCEy9a1ycMHthTTxupJSKPPNCG5vaXLvYW4rCTT8A6gwb5xQdrtD5ZJC2XOPeT
gsz+HEonY+YbqYFcUesZNLHRmV2thLX/vbp55AV6NPDja8G3Lj7eaLl+rp9iq0D2
syO2m5/P9ZX25Tpaa7nL
=K/AJ
-----END PGP SIGNATURE-----