samba-tool: error handling improvements in delegation.py and samdb.py

[Jelmer Vernooij]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

On 21/10/11 23:56, Giampaolo Lauria wrote:
> I have put a set of patches on github to improve the way we handle the
> samba-tool delegation exceptions.
>
> To view the changes, please follow this URL:
> https://github.com/lauria/Samba4/commits/master
>
> Your comments are very much appreciated.
The changes in general look reasonable. I have some comments, most
related to form:

There is a lot of unnecessary reformatting of the code at the same time,
which makes it hard to spot what the actually code changes are.

The first line of the commit message is the same for all four commit
messages, it would be nice to have something more descriptive.

The error message about on|off is perhaps a bit clearer than it was
previously, but it would be even better to tell the user what actually
went wrong. E.g. "expected argument 'on' or 'off', got '%s'".

With regard to the flags string argument - it would be nice to use a
more user friendly message rather than whatever happens to be the name
of the constant in the Samba source code.


>
>
> NB You don't need an account on github to view the patches
It looks like different reviewers have different preferences...

I'm not a big fan of posting links to repositories for review. It makes
it harder to provide context when replying, and that especially makes it
harder for others on the list who haven't looked at repository on GitHub
to easily track what's going on. It's also pretty hard to review
repositories on GitHub when travelling - it's a lot easier to grab an
offline copy of my entire mailbox.

Cheers,

Jelmer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJOof9KAAoJEACAbyvXKaRXZpcP/2u1ylRpdpVcGhrXphzi96lV
wbfuS4AhQeamxNJlcLQqJoyKKt/QrV7s1aJBqOtzkta5rV3n78eyn/ZopEZ82S5f
/ALzJvVbqDAFY2REIb7Z1sGLiOB8wJweX5IFZY3n1s0FxTUyS48/UdhjZk9y3Gwh
XbrcYT/3XoDBFVeDGuFd65SmCkHz/DHVXFMFJp06MttDBedRVnRYa0nzoZjFMMK9
R8uxFLfUroeqxc1WeSWmZNaBpPdH91SJR3Hxas5D79rjjoW2CzNGSxTa07y+gagc
7LGDwv6tm9gD+sl1u5eh/ARFFd5OjwW1AvBMsJ9WP292LyZZicr5EvRh6Vlm47CN
SX6hLCREc2+EAyIKp1ToYR6oo8mgNCce623kcYaAqlEnXeCLuFZAAewjFi1QzBW5
J2M+/NEr9HAWc+EOqccu/7SVjDzWRu72JGOBvdTQ2Zj7DyTWx9lISY0w15qgqkrw
8ULKOJdul45TXpgHp8ke/5uY+x6bIYk6coAywdzBoEHUXwDKdBXDRmYbNv23MhuG
hLvjvX6z5bmQ/ECakE2P1Nhpk4rLhFyRAYFUcjT6c0Iqw2IUuH6R5Q7ILs/ACpXe
z+cjKf606VUefabE7P9plCcMaOUipXGJOJIJBkNGqw1/g+5hezZcTNbsiHBaQnBX
4wtv+OHw2/UQ6Zk1rny+
=3Vc6
-----END PGP SIGNATURE-----