samba-tool user add name change to create patch
jelmer at samba.org
Mon Oct 17 15:34:43 MDT 2011
-----BEGIN PGP SIGNED MESSAGE-----
On 10/17/2011 10:52 PM, Theresa Halloran wrote:
> Find attached a patch to change the*samba-tool user add* command to
*samba-tool user create*.
This change seems reasonable to me. It might be useful to add a dummy
command that warns users that "samba-tool user add" is deprecated and
then calls out to "samba-tool user create". The documentation (wiki
page) will also need to be updated.
> On 10/17/2011 2:32 PM, Theresa Halloran wrote:
>> Jelmer, thanks for the quick reply...
>> On 10/17/2011 12:26 PM, Jelmer Vernooij wrote:
> Hi Theresa,
> On 10/17/2011 05:44 PM, Theresa Halloran wrote:
> I also changed the samba-tool user add to samba-tool user create. I
> think create is more accurate than add since the user is being created
> with this command, as opposed to added, which is used for e.g. when we
> add a user to a group...in the add case the user already exists.
> It might make sense to split up these changes ("net user add -> net user
> create" and the help improvements), so they can be discussed and landed
> separately (and one doesn't have to block on the other).
> >> I will split the patches and discussion.
> The renaming of "net user add" to "net user create" seems reasonable to me.
> >> Ok
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
-----END PGP SIGNATURE-----
More information about the samba-technical