[PATCH] [RFC] moving samba tool tests to dedicated directory

[Jelmer Vernooij]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/17/2011 10:15 PM, Sean Dague wrote:
> On 10/17/2011 03:56 PM, Jelmer Vernooij wrote:
>> Hi Sean,
>>
>> On Mon, Oct 17, 2011 at 03:20:45PM -0400, Sean Dague wrote:
>>> I'd like to move and extend samba-tool blackbox testing. The
>>> following rfc patch would duplicate the existing samba-tool time
>>> test as an example. The goal here would be making it easy to add in
>>> tests for all of the samba-tool commands to verify the tool in our
>>> environment.
>>>
>>> This test can be run with:
>>>
>>> make test TESTS=samba4.blackbox.samba_tool.time
>>>
>>> the time test is really simple, so the power of this will be seen on
>>> things like user. But before going down that road too far I'd like
>>> to get early review on this.
>> Thanks for helping improve the unit tests for samba-tool.
>>
>> Please add new tests under samba.tests, where the existing tests for
netcmd
>> reside, rather than under samba.netcmd. Your tests also seem to
duplicate some
>> of the infrastructure that is already present in the tests there (see
samba.tests.netcmd),
>> including the functionality to easily run samba-tool subcommands.
>
> Ok, do you mean under source4/scripting/python/samba/tests/blackbox ?
Where samba_tool_drs.py exists? Is see there is some existing python
helpers there which I'd not yet found.
source4/scripting/python/samba/tests/netcmd.py IIRC

Cheers,

Jelmer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJOnJOrAAoJEACAbyvXKaRXaGQQAIhoIQcyFnHQp7Tfhvpk5GAa
AU9IBaCsaq/25XutGUzhaGch6R0xCuODxK7b/hyapFR7SOq1CPIyjk0Cydb80sCE
PvI/X1F8UJA9V7BPFlT8qaeu3G8SNGkODqgGuVt6ur8tgy5U03rAZMAGiQ8M4AXC
zbsLvLhBXg8DhW3S6YiIipCqhD5j43W7GZnVds8EgIn1dbIJf2/0AC8IZCJsHzmi
qLT39cdoEUPo9MIoO83bhpmBgaktJeDJ4KI/sHWHEplMrTk1C8t+uWBasB5AlMkW
4EafzPtG2ungJ/bAR3zt88RkECcCvamU7kLgHk0lbtZaXYFYs9X0+XcEKJpqMxWi
nkgs8zay5A0yhO2eCjSiBCSFPwW78pu7KM2ZAos4iMnVATMiS0h8P/k7VbpoGAUH
N+3gGg5bJkhmvAmzCLpEKYcZGseJdkVGii8gfT+iTQkMzzSZIVQwUnryk2Vhnbs3
LK8j66l1B+JbRDGhSeAc32S8ARokDu33caiJxVw48tuQk8Tah3E5Ysu/vT+qr9JZ
jKZj7aYM8i1HOsWtijkPhpGMTERQE7rWNfZygeGZYmcrnH2DaMXAyeDiiUJy46E3
8plUR86tHV/lWaOOVZHNm3b/TjQ5yGvXhKsZevkr7UV1fehB0o9mfbTvFwU8xQX+
OlL3LSzfqkCcB7VIdZeR
=7VeK
-----END PGP SIGNATURE-----