[PATCH] [RFC] moving samba tool tests to dedicated directory

Sean Dague sdague at linux.vnet.ibm.com
Mon Oct 17 14:15:23 MDT 2011

On 10/17/2011 03:56 PM, Jelmer Vernooij wrote:
> Hi Sean,
> On Mon, Oct 17, 2011 at 03:20:45PM -0400, Sean Dague wrote:
>> I'd like to move and extend samba-tool blackbox testing. The
>> following rfc patch would duplicate the existing samba-tool time
>> test as an example. The goal here would be making it easy to add in
>> tests for all of the samba-tool commands to verify the tool in our
>> environment.
>> This test can be run with:
>> make test TESTS=samba4.blackbox.samba_tool.time
>> the time test is really simple, so the power of this will be seen on
>> things like user. But before going down that road too far I'd like
>> to get early review on this.
> Thanks for helping improve the unit tests for samba-tool.
> Please add new tests under samba.tests, where the existing tests for netcmd
> reside, rather than under samba.netcmd. Your tests also seem to duplicate some
> of the infrastructure that is already present in the tests there (see samba.tests.netcmd),
> including the functionality to easily run samba-tool subcommands.

Ok, do you mean under source4/scripting/python/samba/tests/blackbox ? 
Where samba_tool_drs.py exists? Is see there is some existing python 
helpers there which I'd not yet found.

I had previously found source4/utils/tests/test_samba_tool.sh (which is 
run via blackbox) and was basing things on that. Should that get moved 
into this new pool of tests as well?



Sean Dague
IBM Linux Technology Center
email: sldague at us.ibm.com
alt-email: sdague at linux.vnet.ibm.com

More information about the samba-technical mailing list