[SCM] Samba Shared Repository - branch master updated
jelmer at samba.org
Wed Oct 12 17:03:09 MDT 2011
On Thu, Jul 21, 2011 at 04:59:03AM +0200, Andrew Tridgell wrote:
> commit f6fa8684896b8f3f9f8b7bd3742c99906973274c
> Author: Giampaolo Lauria <lauria2 at yahoo.com>
> Date: Fri Jul 15 12:07:03 2011 -0400
> samba-tool: moved takes_optiongroups definition to Command base class
> The option groups should be defined at the Command base class level as they are in common across all samba-tool commands.
> Major move advantages:
> 1. more OOP approach
How is this more object oriented?
> 2. enforcing consistency across commands
> 3. avoiding the need of declaring for every new command
This is really confusing. It means that if you create a new command
you have to know about these default option groups, and the fact that
your run() method has to take 3 extra parameters. If you later
override takes_optiongroups some of these arguments will no longer be
It makes it harder to add a simple command, and gradually extend it.
Also, not every command takes these option groups, that's why they're
Can we please revert this?
More information about the samba-technical