enhancing samba-tool tests questions
jelmer at samba.org
Wed Oct 12 14:48:54 MDT 2011
-----BEGIN PGP SIGNED MESSAGE-----
On 10/12/2011 10:21 PM, Sean Dague wrote:
> I'm trying to get my head wrapped around any automated testing for
samba-tool. After poking around the tree a bit, and getting some
pointers from Theresa, I'm now assuming the tests, as they exist, are
the ones that live source4/utils/tests/test_samba_tool.sh which are
invoked by "make test TESTS=samba4.blackbox.samba_tool"
> Are there any others I should be looking at?
> The test_samba_tool.sh is very basic, just having the time command.
Enhancing that seems like it would be useful.
> Also, with the test scripts, is there any reason these could not be
done in python as long as they comply to the same test program output?
It looks like those are indeed the only tests at the moment.
Tests for individual commands are probably best done as Python unit
tests that directly invoke the command classes. There is a (very very
basic) beginning of that in source4/scripting/python/samba/tests/netcmd.py.
I've added some basic tests for "samba-tool testparm" as an example
there; should land in git master shortly.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
-----END PGP SIGNATURE-----
More information about the samba-technical