enhancing samba-tool tests questions

[Jelmer Vernooij]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Sean,

On 10/12/2011 10:21 PM, Sean Dague wrote:
> I'm trying to get my head wrapped around any automated testing for
samba-tool. After poking around the tree a bit, and getting some
pointers from Theresa, I'm now assuming the tests, as they exist, are
the ones that live source4/utils/tests/test_samba_tool.sh which are
invoked by "make test TESTS=samba4.blackbox.samba_tool"
>
> Are there any others I should be looking at?
>
> The test_samba_tool.sh is very basic, just having the time command.
Enhancing that seems like it would be useful.
>
> Also, with the test scripts, is there any reason these could not be
done in python as long as they comply to the same test program output?
It looks like those are indeed the only tests at the moment.

Tests for individual commands are probably best done as Python unit
tests that directly invoke the command classes. There is a (very very
basic) beginning of that in source4/scripting/python/samba/tests/netcmd.py.

I've added some basic tests for "samba-tool testparm" as an example
there; should land in git master shortly.

Cheers,

Jelmer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJOlf02AAoJEACAbyvXKaRXR0cQAIOiaAkaKf3Y9nZVKMaeMv+8
Lmhu3EycquxP1oFJuQlL45BGCUw6g6mG36HMeiMPZxlJS4YmRQ0tPe1VjbhCPLeT
EuJCoeQO9Mpmy58HAyHnT76Ng8zH/83quZKsyt2FICrUobXWpriBA2IWzmDTsgKY
yVbtOSFZDQVLhM8Z31cxjE8ldOZwp3T1A286w9WZz8+8vEcbubjoNBNKvWiPCnE2
J19SdE6itN8jDM/CPEhZ7UaQWz+VVwXyUq4zMbB1G1eK3IEsi5d6IVW2dS3u8CgX
1Ckmacjgg9/xHtVzk5+QGOCY7iKqlcHRFBxea92/nT5xLFRgv2ZIWeSr1AUEPSus
H9ncD7F4TAkK6usE7Nxcs1njjjH/tZPzIcROcrorcrc3H45XK6ypwQMYviQMtveM
c0AEaM5Dw/4Q0Tc6auM3knsQazVuYJW6uV3E6Mal34vOiPqY1QTEXjMWbfGlIml3
kL0WSQC7fwxfvVhl1rpO3NQgifJnBbuiq2ONg7y5+kGdLMiPuy0KM8GUFx4MS4NO
3OMqhcP5NBqjCL7F4vWgnFkp8QdYfh1CsRerdsAFTcn2q4YHjXDLWSotJRZle7NM
acg8duLCqDMHqe1q2au9x6lC5T14x9Ae1G3yddWcnF10017+fq7sz/BVOR7LdbA4
I5fUNW1wMsTmUU3g5cYP
=0P9x
-----END PGP SIGNATURE-----