s4: "findprovisionusnranges" helper
Matthias Dieter Wallnöfer
mdw at samba.org
Fri Oct 7 02:11:19 MDT 2011
Matthieu Patou wrote:
> On 01/10/2011 09:21, Matthias Dieter Wallnöfer wrote:
>> Matthieu Patou wrote:
>>> On 30/09/2011 08:39, Matthias Dieter Wallnöfer wrote:
>>>> Hi ekacnet,
>>>> after looking at bug report #8504
>>>> (https://bugzilla.samba.org/show_bug.cgi?id=8504) I stumbled over
>>>> "scripting/bin/findprovisionusnranges" which acts as helper for
>>>> several other python scripts ("provision", "upgradeprovision",
>>>> "samba-tool dbcheck") but at the moment doesn't get installed.
>>>> To fix this for "samba-tool dbcheck" which should be runnable after
>>>> installation we could patch like this:
>>>> or, as Jelmer proposed on the patch review, convert it to a python
>>>> module. What's your opinion?
>>> Sure a module would be nicer. Please feel free to rewrite it as a
>>> module in the upgrade_helpers.
>> I don't know if I am able to do this since I'm not really expert in
>> python. But do you think it is okay for now to install
>> "findprovisionusnranges" under s4's "sbin" directory?
> I didn't had a look really at this, I had several stuff to look at
> last week at IOLAB and this week is overloaded with my support job.
> What about putting this as a module and make upgradeprovision
> --addprovisionusn to the job of findprovisionusnranges ?
Yes, the point is if you (please) could pick this up since I'm really
not familiar with this code. But if you don't get a chance to do this
soon I would prefer pushing my patch (immediate fix).
More information about the samba-technical