patches for time limited getncchanges

Matthieu Patou mat at
Mon Nov 21 14:25:37 MST 2011

On 21/11/2011 20:30, Stefan (metze) Metzmacher wrote:
> Hi Matthieu,
> I've pushed my latest version of it here:
>> I squashed what was needed and added the needed code for
>> replmd_replicated_apply_merge, I pushed all the code in my repo in the
>> drs branch:
>> I think it should be ok, it does the job both (in term of adding the
>> isRecycled) for new objects and updated objects.
> I think we need to test how replication works if an object is restored.
> Does it just work by removing the 'isDeleted' attribute or by setting it
> to 'FALSE'?
Most of the test, test the value so it should be an issue appart for the 
_merge, here we can afford to search for the value if the metadata is found.

> In case of replication I guess the meta data stamp for 'isDeleted' will
> always be
> there, so checking for the existence of the related stamp, may not indicate
> the object has isDeleted: TRUE.
I don't think it's an issue for the _add because I think I compare the 
value (I need to recheck).
> In replmd_replicated_apply_merge() we also need to cover the case, where
> the isDeleted: TRUE is already in the local ldb.
Here it's sure.
> I think we need to calculate how the new object will look like first
> and then check if we still need to add isRecycled: TRUE.
Sorry I didn't understand this phrase.
> metze


Matthieu Patou
Samba Team

More information about the samba-technical mailing list