patches for time limited getncchanges

Stefan (metze) Metzmacher metze at
Mon Nov 21 12:30:58 MST 2011

Hi Matthieu,

I've pushed my latest version of it here:;a=shortlog;h=refs/heads/master4-tmp3

> I squashed what was needed and added the needed code for
> replmd_replicated_apply_merge, I pushed all the code in my repo in the
> drs branch:
> I think it should be ok, it does the job both (in term of adding the
> isRecycled) for new objects and updated objects.

I think we need to test how replication works if an object is restored.

Does it just work by removing the 'isDeleted' attribute or by setting it
to 'FALSE'?

In case of replication I guess the meta data stamp for 'isDeleted' will
always be
there, so checking for the existence of the related stamp, may not indicate
the object has isDeleted: TRUE.

In replmd_replicated_apply_merge() we also need to cover the case, where
the isDeleted: TRUE is already in the local ldb.

I think we need to calculate how the new object will look like first
and then check if we still need to add isRecycled: TRUE.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <>

More information about the samba-technical mailing list