[Patch] make sure credits are granted properly for compound requests

Jeremy Allison jra at samba.org
Mon Nov 14 15:02:35 MST 2011

On Mon, Nov 14, 2011 at 06:54:06PM +0100, Christian M Ambach wrote:
> Hi Jeremy, hi Metze,
> I've made a patch that makes sure that smbd grants all credits requested in the
> individual requests of a compound request instead of just for the last request
> of the compound.
> Otherwise a client can be left without credits.
> Behavior however is still different to Windows as Windows grants all credits
> just in the last reply and not individually.
> Shall I refine the patch to we match Windows behavior or put it into Samba
> as-is?

I don't think this patch is quite right - if the last element
in a compound set goes async we'll end up counting the credits
twice with this fix.

I am testing a modified version that should make us behave
identically to Windows. Give me a few hours to test..



More information about the samba-technical mailing list