patches for time limited getncchanges
Stefan (metze) Metzmacher
metze at samba.org
Mon Nov 14 12:47:54 MST 2011
> I'm planning to push tomorrow my patches for the isRecycled and for time
> limited getncchanges.
Which is the exact branch?
> The latter ones received a review from tridge, and for the first one
> it's from you.
Why did you already pushed
I asked you to use "TRUE" and "FALSE" together with strncmp().
Also I'd expected that you push this together with the rest of
> I decided not to include the patch
> about the sorting or the lack of sorting for the base DN.
> I think it's worthwhile not to sort as we can cope with it and my tests
> with windows has shown that windows can cope too.
> It saves us a big sort that can costly on a big amount of objects, but I
> don't want to delay too much my patches for something that is not
> currently critical.
> Then branch I plan to push is at
That's a commit url not a branch.
> If no objection I'll push it.
Please don't push.
is wrong, it means we'd crash as changes is uninitialized.
Also, I still think we should always sort.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 262 bytes
Desc: OpenPGP digital signature
More information about the samba-technical